feat: updating imports and llm cut off chunking - #105
Merged
Conversation
|
| Filename | Overview |
|---|---|
| app/api/v1/routes/call_imports.py | Adds structured parse results, row-skip tracking, and partial import support. |
| app/services/call_imports/bulk_ops.py | Persists skipped-row details and marks imports with no usable rows as failed. |
| app/workers/tasks/helpers/llm_diarisation.py | Adds model-specific output budgets and rejects truncated responses. |
| frontend/src/pages/callImports/CallImportDetail.tsx | Displays skipped-row information for partial imports and updates diarisation guidance. |
| app/models/schemas.py | Adds the skipped-row response shape and expands metric text validation limits. |
Reviews (2): Last reviewed commit: "feat: updating long test inputs" | Re-trigger Greptile
| </div> | ||
| )} | ||
|
|
||
| {(data.source_row_skips?.length ?? 0) > 0 && data.total_rows > 0 && ( |
There was a problem hiding this comment.
When every source row is skipped, materialization stores the row details but sets total_rows to zero. This condition then hides those details, so the failed import does not show which rows and values need correction.
Suggested change
| {(data.source_row_skips?.length ?? 0) > 0 && data.total_rows > 0 && ( | |
| {(data.source_row_skips?.length ?? 0) > 0 && ( |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
Briefly describe what this PR changes.
Why?
Explain the problem this solves and why this approach was chosen.
How to Test?
List clear steps for reviewers to verify the change.
Release Label
Select one semantic version bump intent for this PR:
major- breaking change, next release bumps major versionminor- backward-compatible feature, next release bumps minor versionfix- backward-compatible bug fix, next release bumps patch versionIf you do not have permission to apply labels, mention the intended release label here and a maintainer will set it.
Checklist
CONTRIBUTING.mdguide.